[EJBCLIENT-225] Reinstate ignored test cases post EJBCLIENT-216.

[rachmatowicz]

The PR un-ignores the two cluster-based test cases which will pass now that EJBCLIENT-216 is merged.

[wildfly-ci]

Build 587 outcome was FAILURE using a merge of 423669f
Summary: Tests failed: 1 (1 new), passed: 6 Build time: 00:00:19

Failed tests

org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation: java.lang.IllegalStateException: EJBCLIENT000024: Not able to find EJB matching "StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb""
	at org.jboss.ejb.client.EJBClientContext.discoverAffinityCluster(EJBClientContext.java:893)
	at org.jboss.ejb.client.EJBClientContext.performLocatedAction(EJBClientContext.java:694)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:162)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:112)
	at com.sun.proxy.$Proxy8.echo(Unknown Source)
	at org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation(ClusteredInvocationTestCase.java:135)
------- Stdout: -------
06:24:13,901 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@1a07e12
06:24:13,913 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node1
06:24:13,913 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@f7cfd9
06:24:13,918 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node2
06:24:13,918 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@1a07e12
06:24:13,919 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@f7cfd9
06:24:13,919 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb: server org.jboss.ejb.client.test.common.DummyServer@f7cfd9
06:24:13,919 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb:  server org.jboss.ejb.client.test.common.DummyServer@f7cfd9
06:24:13,919 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Testing invocation on SLSB proxy with ClusterAffinity
06:24:13,920 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Created proxy for Echo: Proxy for remote EJB StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb"
06:24:13,920 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Invoking on proxy...
06:24:13,960 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node1
06:24:13,960 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node2
06:24:13,964 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node1
06:24:13,965 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node2

[rachmatowicz]

Looking into this. Unfortunately, when a client can't find a deployment, there isn't a lot of useful information provided as with the old client. We might want to think about addressing this somehow.

[wildfly-ci]

Build 592 outcome was FAILURE using a merge of 386d616
Summary: Tests failed: 1, passed: 6 Build time: 00:00:18

Failed tests

org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation: java.lang.IllegalStateException: EJBCLIENT000024: Not able to find EJB matching "StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb""
	at org.jboss.ejb.client.EJBClientContext.discoverAffinityCluster(EJBClientContext.java:893)
	at org.jboss.ejb.client.EJBClientContext.performLocatedAction(EJBClientContext.java:694)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:162)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:112)
	at com.sun.proxy.$Proxy8.echo(Unknown Source)
	at org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation(ClusteredInvocationTestCase.java:135)
------- Stdout: -------
08:33:35,606 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@1a07e12
08:33:35,609 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node1
08:33:35,609 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@f7cfd9
08:33:35,613 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node2
08:33:35,613 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@1a07e12
08:33:35,614 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@f7cfd9
08:33:35,614 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb: server org.jboss.ejb.client.test.common.DummyServer@f7cfd9
08:33:35,614 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb:  server org.jboss.ejb.client.test.common.DummyServer@f7cfd9
08:33:35,614 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Testing invocation on SLSB proxy with ClusterAffinity
08:33:35,615 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Created proxy for Echo: Proxy for remote EJB StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb"
08:33:35,615 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Invoking on proxy...
EJBClientChannel: registering ServiceURL: service:ejb.jboss:node:node1;cluster=ejb
EJBClientChannel: registering ServiceURL: service:ejb.jboss:remote://localhost:6999;node=node1;source-ip=127.0.0.1/24
EJBClientChannel: registering ServiceURL: service:ejb.jboss:node:node2;cluster=ejb
EJBClientChannel: registering ServiceURL: service:ejb.jboss:remote://localhost:7099;node=node2;source-ip=127.0.0.1/24
08:33:35,646 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node1
08:33:35,646 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node2
08:33:35,653 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node1
08:33:35,655 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node2

[wildfly-ci]

Build 595 outcome was FAILURE using a merge of 826e8b5
Summary: Tests failed: 1, passed: 6 Build time: 00:00:15

Failed tests

org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation: java.lang.IllegalStateException: EJBCLIENT000024: Not able to find EJB matching "StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb""
	at org.jboss.ejb.client.EJBClientContext.discoverAffinityCluster(EJBClientContext.java:893)
	at org.jboss.ejb.client.EJBClientContext.performLocatedAction(EJBClientContext.java:694)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:162)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:112)
	at com.sun.proxy.$Proxy8.echo(Unknown Source)
	at org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation(ClusteredInvocationTestCase.java:135)
------- Stdout: -------
10:07:40,554 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@1a07e12
10:07:40,558 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node1
10:07:40,558 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@f7cfd9
10:07:40,561 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node2
10:07:40,561 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@1a07e12
10:07:40,561 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@f7cfd9
10:07:40,562 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb: server org.jboss.ejb.client.test.common.DummyServer@f7cfd9
10:07:40,562 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb:  server org.jboss.ejb.client.test.common.DummyServer@f7cfd9
10:07:40,562 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Testing invocation on SLSB proxy with ClusterAffinity
10:07:40,562 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Created proxy for Echo: Proxy for remote EJB StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb"
10:07:40,563 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Invoking on proxy...
EJBClientChannel: registering ServiceURL: service:ejb.jboss:node:node1;cluster=ejb
EJBClientChannel: registering ServiceURL: service:ejb.jboss:remote://localhost:6999;node=node1;source-ip=127.0.0.1/24
EJBClientChannel: registering ServiceURL: service:ejb.jboss:node:node2;cluster=ejb
EJBClientChannel: registering ServiceURL: service:ejb.jboss:remote://localhost:7099;node=node2;source-ip=127.0.0.1/24
10:07:40,590 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node1
10:07:40,590 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node2
EJBClientChannel: removing ServiceURLs for cluster : ejb
10:07:40,595 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node1
10:07:40,596 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node2

[wildfly-ci]

Build 596 outcome was FAILURE using a merge of c92ae2d
Summary: Tests failed: 1, passed: 6 Build time: 00:00:13

Failed tests

org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation: java.lang.IllegalStateException: EJBCLIENT000024: Not able to find EJB matching "StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb""
	at org.jboss.ejb.client.EJBClientContext.discoverAffinityCluster(EJBClientContext.java:893)
	at org.jboss.ejb.client.EJBClientContext.performLocatedAction(EJBClientContext.java:694)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:162)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:112)
	at com.sun.proxy.$Proxy8.echo(Unknown Source)
	at org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation(ClusteredInvocationTestCase.java:135)
------- Stdout: -------
10:14:13,128 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@17acd7b
10:14:13,133 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node1
10:14:13,133 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@ffe6dc
10:14:13,135 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node2
10:14:13,135 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@17acd7b
10:14:13,135 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@ffe6dc
10:14:13,135 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb: server org.jboss.ejb.client.test.common.DummyServer@ffe6dc
10:14:13,135 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb:  server org.jboss.ejb.client.test.common.DummyServer@ffe6dc
10:14:13,136 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Testing invocation on SLSB proxy with ClusterAffinity
10:14:13,136 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Created proxy for Echo: Proxy for remote EJB StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb"
10:14:13,136 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Invoking on proxy...
10:14:13,152 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node1
10:14:13,153 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node2
10:14:13,155 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node1
10:14:13,159 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node2

[rachmatowicz]

Found the problem here. In my test case, I have a non-clustered test and a clustered test, and they use two different legacy properties files: clustered-jboss-ejb-client.properties and jboss-ejb-client.properties. When I run the test case locally, the clustered test case runs first, the non-clustered test case runs second; when I run remotely, it is the other way around.

It seems as though JBossEJBProperties is being initialised statically once and once only for all tests. So, the properties passed to my test cases depend on the test case order. Need a way to reinit the JBossEJBProperties for each test.

[wildfly-ci]

Build 601 outcome was FAILURE using a merge of c92ae2d
Summary: Tests failed: 1, passed: 6 Build time: 00:00:12

Failed tests

org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation: java.lang.IllegalStateException: EJBCLIENT000024: Not able to find EJB matching "StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb""
	at org.jboss.ejb.client.EJBClientContext.discoverAffinityCluster(EJBClientContext.java:893)
	at org.jboss.ejb.client.EJBClientContext.performLocatedAction(EJBClientContext.java:694)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:162)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:112)
	at com.sun.proxy.$Proxy8.echo(Unknown Source)
	at org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation(ClusteredInvocationTestCase.java:135)
------- Stdout: -------
15:19:57,233 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@17acd7b
15:19:57,235 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node1
15:19:57,235 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@ffe6dc
15:19:57,237 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node2
15:19:57,238 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@17acd7b
15:19:57,238 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@ffe6dc
15:19:57,238 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb: server org.jboss.ejb.client.test.common.DummyServer@ffe6dc
15:19:57,238 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb:  server org.jboss.ejb.client.test.common.DummyServer@ffe6dc
15:19:57,238 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Testing invocation on SLSB proxy with ClusterAffinity
15:19:57,238 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Created proxy for Echo: Proxy for remote EJB StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb"
15:19:57,239 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Invoking on proxy...
15:19:57,261 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node1
15:19:57,261 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node2
15:19:57,264 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node1
15:19:57,266 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node2

[wildfly-ci]

Build 604 outcome was FAILURE using a merge of c92ae2d
Summary: Tests failed: 1, passed: 6 Build time: 00:00:12

Failed tests

org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation: java.lang.IllegalStateException: EJBCLIENT000024: Not able to find EJB matching "StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb""
	at org.jboss.ejb.client.EJBClientContext.discoverAffinityCluster(EJBClientContext.java:893)
	at org.jboss.ejb.client.EJBClientContext.performLocatedAction(EJBClientContext.java:694)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:162)
	at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:112)
	at com.sun.proxy.$Proxy8.echo(Unknown Source)
	at org.jboss.ejb.client.test.ClusteredInvocationTestCase.testClusteredSLSBInvocation(ClusteredInvocationTestCase.java:135)
------- Stdout: -------
09:16:22,486 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@5ca843
09:16:22,493 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node1
09:16:22,493 INFO  [org.jboss.ejb.client.test.common.DummyServer] (main) Starting org.jboss.ejb.client.test.common.DummyServer@668b6e
09:16:22,495 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Started server node2
09:16:22,496 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@5ca843
09:16:22,496 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Registered module on server org.jboss.ejb.client.test.common.DummyServer@668b6e
09:16:22,496 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb: server org.jboss.ejb.client.test.common.DummyServer@668b6e
09:16:22,496 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Added node to cluster ejb:  server org.jboss.ejb.client.test.common.DummyServer@668b6e
09:16:22,496 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Testing invocation on SLSB proxy with ClusterAffinity
09:16:22,496 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Created proxy for Echo: Proxy for remote EJB StatelessEJBLocator for "my-foo-app/my-bar-module/Echo", view is interface org.jboss.ejb.client.test.common.Echo, affinity is Cluster "ejb"
09:16:22,497 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Invoking on proxy...
09:16:22,514 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node1
09:16:22,514 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Unregistered module from node2
09:16:22,516 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node1
09:16:22,517 INFO  [org.jboss.ejb.client.test.ClusteredInvocationTestCase] (main) Stopped server node2

[rachmatowicz]

Didn't have a lot of luck in re-initializing the EJBClientContext after it had been statically initialized with the wrong properties file, so opted for running each test in a new JVM (forkMode=always) and setting the JBossEJBProperties ContextManager with the correct default before any tests run.