Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EJBCLIENT-216] Fix generation of clustering-related ServiceURLs #262

Merged
merged 1 commit into from
May 16, 2017

Conversation

rachmatowicz
Copy link
Contributor

@rachmatowicz rachmatowicz commented Apr 28, 2017

This PR makes the following changes:

  • when a topology update arrives, creates one abstract ServiceURL to represent each node in the cluster, and multiple corresponding concrete ServiceURLs to represent the possible client mappings and target URIs associated with that node

This allows performLocatedAction to discover the nodes in a cluster as abstract ServiceURLs and in a second step to resolve them to concrete ServiceURLs.

See this issue for details: https://issues.jboss.org/browse/EJBCLIENT-216

@rachmatowicz
Copy link
Contributor Author

David, this is my first draft of this PR. I am still working on it but wanted you to be able to look at it to see if you agree with the basic approach. There is an issue with affinity which I need to look at, so please don't merge for now.

@dmlloyd dmlloyd added the Hold label Apr 28, 2017
@dmlloyd
Copy link
Member

dmlloyd commented Apr 28, 2017

Looks reasonable so far.

@rachmatowicz
Copy link
Contributor Author

I was trying to write a test case for this by resurrecting DummyServer, but it's going to take me longer than expected. I don't plan any more changes so you can merge now if you like or wait until I get DummyServer working.

@dmlloyd
Copy link
Member

dmlloyd commented May 3, 2017

@rachmatowicz there's a "real" server in the code base now that you can use instead, by providing an Association implementation.

@rachmatowicz
Copy link
Contributor Author

You mean RemoteEJBService(Association, RemotingTransactionService)? This is what I was looking at using...

@dmlloyd dmlloyd removed the Hold label May 16, 2017
@dmlloyd dmlloyd merged commit 6e396a7 into wildfly:master May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants