Support ipywidgets 8 #411
Merged
Support ipywidgets 8 #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Visual differences I'm ok with, do you know if the lab2 build can be fixed? |
Wondering if this might be related to jupyterlab/jupyterlab#11248 according to the log in https://github.com/widgetti/ipyvolume/runs/7516085636?check_suite_focus=true. |
|
Opened #412 to start troubleshooting this. |
|
Ah, I think we need to manually push the visual changes right? Is there a bot that can do that for us? |
|
I opened #413 since this does not seem related to this change. |
|
Bringing this PR out of draft since |
maartenbreddels
force-pushed
the
ipywidgets-8
branch
from
213f20d
to
42dd70d
Compare
|
Failure needs network related. Thanks Jeremy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start testing support for
ipywidgets8.Similar to matplotlib/ipympl#461