Fargate support (3rd iteration) #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2019
andreaswittig
approved these changes
Jan 8, 2019
fargate/service-dedicated-alb.yaml
Outdated
| LoadBalancerDeregistrationDelay: | ||
| Description: 'The amount time (in seconds) to wait before changing the state of a deregistering target from draining to unused.' | ||
| Type: Number | ||
| Default: 300 |
There was a problem hiding this comment.
I would argue, that 60 seconds should be enough for most of the workloads? Speeds up the deployment process a lot.
fargate/service-dedicated-alb.yaml
Outdated
| Cluster: {'Fn::ImportValue': !Sub '${ParentClusterStack}-Cluster'} | ||
| DeploymentConfiguration: | ||
| MaximumPercent: 200 | ||
| MinimumHealthyPercent: 50 |
There was a problem hiding this comment.
Why downgrading the capacity during a deployment? Especially, as we are using Fargate? I'd recommend 100%.
andreaswittig
pushed a commit
that referenced
this pull request
May 16, 2019
[New Template] fargate/cluster - Fargate cluster [New Template] fargate/service-dedicated-alb - Fargate service that runs on a Fargate cluster based on fargate/cluster.yaml and uses a dedicated ALB [Improvement] ecs/cluster - Optional support for ALB access logging and idle timeout [Improvement] ecs/service-dedicated-alb - Optional support for ALB access logging and idle timeout [Improvement] ecs/service-dedicated-alb - Added parameters to control Cpu, Memory, AutoScaling, and HealthCheckGracePeriod [Improvement] ecs/service-cluster-alb - Added parameters to control Cpu, Memory, AutoScaling, and HealthCheckGracePeriod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for AWS Fargate
Todos
NLB integrationChanges
fargate/cluster- Fargate clusterfargate/service-dedicated-alb- Fargate service that runs on a Fargate cluster based on fargate/cluster.yaml and uses a dedicated ALBecs/cluster- Optional support for ALB access logging and idle timeoutecs/service-dedicated-alb- Optional support for ALB access logging and idle timeoutecs/service-dedicated-alb- Added parameters to controlCpu,Memory,AutoScaling, andHealthCheckGracePeriodecs/service-cluster-alb- Added parameters to controlCpu,Memory,AutoScaling, andHealthCheckGracePeriod