Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose origin as ASCII or Unicode #297

Closed
annevk opened this issue Apr 24, 2017 · 1 comment
Closed

Expose origin as ASCII or Unicode #297

annevk opened this issue Apr 24, 2017 · 1 comment
Labels
topic: api topic: idna

Comments

@annevk
Copy link
Member

annevk commented Apr 24, 2017

See whatwg/html#2568. Apparently this is far from interoperable. Relates a little bit to #274.
@annevk annevk added topic: api topic: idna needs implementer interest Moving the issue forward requires implementers to express interest needs tests Moving the issue forward requires someone to write tests and removed needs implementer interest Moving the issue forward requires implementers to express interest labels Apr 24, 2017
annevk added a commit that referenced this issue May 16, 2017
@annevk
Make URL's origin return solely ASCII code points
0098115 
See whatwg/html#2568 for discussion.

See whatwg/html#2689 for the corresponding
change to the HTML Standard.

Closes #297.
@annevk annevk mentioned this issue May 16, 2017
Merged
annevk added a commit to web-platform-tests/wpt that referenced this issue May 16, 2017
@annevk
URL: expect ASCII for origins
c8d694b 
For whatwg/url#297.
@annevk annevk mentioned this issue May 16, 2017
Merged
annevk added a commit to web-platform-tests/wpt that referenced this issue May 18, 2017
@annevk
URL: expect ASCII for origins
562990a 
For whatwg/url#297.
annevk added a commit to web-platform-tests/wpt that referenced this issue May 18, 2017
@annevk
URL: expect ASCII for origins
ee0c244 
For whatwg/url#297.
@annevk annevk removed the needs tests Moving the issue forward requires someone to write tests label May 18, 2017
@annevk
Copy link
Member Author

annevk commented May 18, 2017 •
edited
Loading

FYI: we're going to change URL object's origin attribute to always return ASCII per the discussion in the HTML Standard.

annevk added a commit to web-platform-tests/wpt that referenced this issue May 18, 2017
@annevk
URL: expect ASCII for origins
34435a4 
For whatwg/url#297.
annevk added a commit that referenced this issue May 19, 2017
@annevk
Make URL's origin return solely ASCII code points
20c3257 
See whatwg/html#2568 for discussion.

See whatwg/html#2689 for the corresponding
change to the HTML Standard.

Tests: web-platform-tests/wpt#5944.

Closes #297.
TimothyGu added a commit to TimothyGu/node that referenced this issue May 20, 2017
@TimothyGu
url: expose WHATWG url.origin as ASCII
5a41e97 
Refs: whatwg/url#297
Refs: web-platform-tests/wpt#5944
@TimothyGu TimothyGu mentioned this issue May 20, 2017
Closed
3 tasks
TimothyGu added a commit to nodejs/node that referenced this issue May 25, 2017
@TimothyGu
url: expose WHATWG url.origin as ASCII
413691f 
PR-URL: #13126
Refs: whatwg/url#297
Refs: web-platform-tests/wpt#5944
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
jasnell pushed a commit to nodejs/node that referenced this issue May 25, 2017
@TimothyGu @jasnell
url: expose WHATWG url.origin as ASCII
c42522a 
PR-URL: #13126
Refs: whatwg/url#297
Refs: web-platform-tests/wpt#5944
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
jasnell pushed a commit to nodejs/node that referenced this issue May 28, 2017
@TimothyGu @jasnell
url: expose WHATWG url.origin as ASCII
70cdfc5 
PR-URL: #13126
Refs: whatwg/url#297
Refs: web-platform-tests/wpt#5944
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: api topic: idna
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annevk