-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uos make puppet-wechat great again #206
Conversation
有个lint 报错好像是项目之前就有的报错,是数据没有初始化,和本次提交无管 |
关注一下 |
mark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Please follow my reviews, and also remember to make sure the CI turns green before we can continue reviewing this PR!
package.json
Outdated
@@ -61,6 +62,8 @@ | |||
"@types/qr-image": "^3.2.5", | |||
"@types/request": "^2.48.8", | |||
"@types/xml2js": "^0.4.9", | |||
"qrcode-terminal": "^0.12.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove unrelated dependencies.
src/puppet-wechat.ts
Outdated
@@ -82,6 +80,7 @@ type PuppetWeChatOptions = PUPPET.PuppetOptions & { | |||
launchOptions? : LaunchOptions | |||
stealthless? : boolean | |||
uos? : boolean | |||
token? : string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain what's this token
for? It seems that it does not been referenced in the new code.
LGTM |
uos 协议又可以重新使用了