Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct method in docs #68

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

timneutkens
Copy link
Contributor

I noticed this while writing a webpack plugin, tap can't return a modification, register can, so that's the correct method to show.

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #68   +/-   ##
======================================
  Coverage    91.9%   91.9%           
======================================
  Files          15      15           
  Lines         519     519           
  Branches       71      71           
======================================
  Hits          477     477           
  Misses         39      39           
  Partials        3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b67d42...05ee408. Read the comment docs.

@TheLarkInn TheLarkInn merged commit 04e5211 into webpack:master Jul 5, 2018
@TheLarkInn
Copy link
Member

Thanks 🙇🙇

@timneutkens timneutkens deleted the fix/interception-docs branch July 5, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants