Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: use eslint 9 #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ricardogobbosouza
Copy link

I refactored the eslint settings to use the new flat config

@ricardogobbosouza
Copy link
Author

It's still a draft, wdyt @alexander-akait ?

env: {
es6: true,
jest: true
// require('./rules/imports'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is comment?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are very long... maybe we have sme hacks to still use it?

...{
languageOptions: {
ecmaVersion: 2018,
sourceType: 'module',
Copy link
Member

@alexander-akait alexander-akait May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a problem, some packages are still in commonjs

Let's make two things - "@webpack-contrib/eslint-config-webpack/commonjs" and "@webpack-contrib/eslint-config-webpack/module" and the second requires extension for import ... from ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants