Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UTF-8 encoding check in JWEBuilder #554

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

Spomky
Copy link
Member

@Spomky Spomky commented Apr 10, 2024

The UTF-8 encoding validation for the payload in the JWEBuilder has been removed. This modification was necessary because the check was unnecessarily restrictive and caused issues in certain use-cases. Now, any string can be used as the payload without throwing an InvalidArgumentException.

Target branch:
Resolves issue #

  • It is a Bug fix
  • It is a New feature
  • It is related to dependencies

Includes:

  • Breaks BC
  • Deprecations

The UTF-8 encoding validation for the payload in the JWEBuilder has been removed. This modification was necessary because the check was unnecessarily restrictive and caused issues in certain use-cases. Now, any string can be used as the payload without throwing an InvalidArgumentException.
@Spomky Spomky added the bug label Apr 10, 2024
@Spomky Spomky added this to the 3.4.1 milestone Apr 10, 2024
@Spomky Spomky self-assigned this Apr 10, 2024
@Spomky Spomky linked an issue Apr 10, 2024 that may be closed by this pull request
@Spomky Spomky merged commit 8342de7 into 3.4.x Apr 10, 2024
12 checks passed
@Spomky Spomky deleted the bugs/binary-content-jwe branch April 10, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It isn't possible to encrypt binary data !?
1 participant