Prevent bad design by using named constructors #320
Spomkyintegrate.yml
on: pull_request
3️⃣ Static Analysis
47s
4️⃣ Coding Standards
1m 21s
5️⃣ Mutation Testing
8m 0s
6️⃣ Rector Checkstyle
2m 10s
7️⃣ Exported files
3s
Matrix: 2️⃣ Unit and functional tests
Annotations
10 warnings
|
5️⃣ Mutation Testing:
src/Bundle/JoseFramework/Routing/JWKSetLoader.php#L23
Escaped Mutant for Mutator "PublicVisibility":
--- Original
+++ New
@@ @@
{
$this->routes = new RouteCollection();
}
- public function add(string $pattern, string $name) : void
+ protected function add(string $pattern, string $name) : void
{
$defaults = ['_controller' => $name];
$route = new Route($pattern, $defaults);
|
|
5️⃣ Mutation Testing:
src/Bundle/JoseFramework/Routing/JWKSetLoader.php#L25
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
}
public function add(string $pattern, string $name) : void
{
- $defaults = ['_controller' => $name];
+ $defaults = [];
$route = new Route($pattern, $defaults);
$this->routes->add(sprintf('jwkset_%s', $name), $route);
}
|
|
5️⃣ Mutation Testing:
src/Bundle/JoseFramework/Routing/JWKSetLoader.php#L29
Escaped Mutant for Mutator "MethodCallRemoval":
--- Original
+++ New
@@ @@
{
$defaults = ['_controller' => $name];
$route = new Route($pattern, $defaults);
- $this->routes->add(sprintf('jwkset_%s', $name), $route);
+
}
/**
* {@inheritdoc}
|
|
5️⃣ Mutation Testing:
src/Bundle/JoseFramework/Routing/JWKSetLoader.php#L45
Escaped Mutant for Mutator "Identical":
--- Original
+++ New
@@ @@
*/
public function supports(mixed $resource, string $type = null) : bool
{
- return $type === 'jwkset';
+ return $type !== 'jwkset';
}
public function getResolver() : LoaderResolverInterface
{
|
|
5️⃣ Mutation Testing:
src/Bundle/JoseFramework/Serializer/JWEEncoder.php#L47
Escaped Mutant for Mutator "InstanceOf_":
--- Original
+++ New
@@ @@
}
public function encode(mixed $data, string $format, array $context = []) : string
{
- if ($data instanceof JWE === false) {
+ if (true === false) {
throw new LogicException('Expected data to be a JWE.');
}
try {
|
|
5️⃣ Mutation Testing:
src/Bundle/JoseFramework/Serializer/JWEEncoder.php#L53
Escaped Mutant for Mutator "MBString":
--- Original
+++ New
@@ @@
throw new LogicException('Expected data to be a JWE.');
}
try {
- return $this->serializerManager->serialize(mb_strtolower($format), $data, $this->getRecipientIndex($context));
+ return $this->serializerManager->serialize(strtolower($format), $data, $this->getRecipientIndex($context));
} catch (Throwable $ex) {
throw new NotEncodableValueException(sprintf('Cannot encode JWE to %s format.', $format), 0, $ex);
}
|
|
5️⃣ Mutation Testing:
src/Bundle/JoseFramework/Serializer/JWEEncoder.php#L58
Escaped Mutant for Mutator "DecrementInteger":
--- Original
+++ New
@@ @@
try {
return $this->serializerManager->serialize(mb_strtolower($format), $data, $this->getRecipientIndex($context));
} catch (Throwable $ex) {
- throw new NotEncodableValueException(sprintf('Cannot encode JWE to %s format.', $format), 0, $ex);
+ throw new NotEncodableValueException(sprintf('Cannot encode JWE to %s format.', $format), -1, $ex);
}
}
public function decode(string $data, string $format, array $context = []) : JWE
|
|
5️⃣ Mutation Testing:
src/Bundle/JoseFramework/Serializer/JWEEncoder.php#L58
Escaped Mutant for Mutator "IncrementInteger":
--- Original
+++ New
@@ @@
try {
return $this->serializerManager->serialize(mb_strtolower($format), $data, $this->getRecipientIndex($context));
} catch (Throwable $ex) {
- throw new NotEncodableValueException(sprintf('Cannot encode JWE to %s format.', $format), 0, $ex);
+ throw new NotEncodableValueException(sprintf('Cannot encode JWE to %s format.', $format), 1, $ex);
}
}
public function decode(string $data, string $format, array $context = []) : JWE
|
|
5️⃣ Mutation Testing:
src/Bundle/JoseFramework/Serializer/JWEEncoder.php#L67
Escaped Mutant for Mutator "DecrementInteger":
--- Original
+++ New
@@ @@
try {
return $this->serializerManager->unserialize($data);
} catch (Exception $ex) {
- throw new NotEncodableValueException(sprintf('Cannot decode JWE from %s format.', $format), 0, $ex);
+ throw new NotEncodableValueException(sprintf('Cannot decode JWE from %s format.', $format), -1, $ex);
}
}
/**
|
|
5️⃣ Mutation Testing:
src/Bundle/JoseFramework/Serializer/JWEEncoder.php#L67
Escaped Mutant for Mutator "IncrementInteger":
--- Original
+++ New
@@ @@
try {
return $this->serializerManager->unserialize($data);
} catch (Exception $ex) {
- throw new NotEncodableValueException(sprintf('Cannot decode JWE from %s format.', $format), 0, $ex);
+ throw new NotEncodableValueException(sprintf('Cannot decode JWE from %s format.', $format), 1, $ex);
}
}
/**
|