-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(new_split_chunks): support splitChunks.name
#2955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac6cac0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
team
The issue/pr is created by the member of Rspack.
label
Apr 27, 2023
This comment was marked as outdated.
This comment was marked as outdated.
hyf0
force-pushed
the
hyf_2834e2390840928340
branch
from
May 5, 2023 05:24
33cf6c4
to
d310dea
Compare
hyf0
changed the title
test(split_chunks): migrate split-chunks-common/simple
feat(new_split_chunks): support May 5, 2023
splitChunks.name
hyf0
force-pushed
the
hyf_2834e2390840928340
branch
from
May 5, 2023 06:42
0564b81
to
93086f9
Compare
hyf0
force-pushed
the
hyf_2834e2390840928340
branch
from
May 5, 2023 07:55
0ad53c6
to
ac6cac0
Compare
ahabhgk
approved these changes
May 5, 2023
This was referenced May 9, 2023
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
Summary
splitChunks.name
🤖 Generated by Copilot at 0564b81
This pull request adds support for naming chunks and cache groups in the split chunks plugin of
rspack
, a web development tool. It introduces a newname
field to the user configuration and the internal options, and a newChunkNameGetter
function to generate chunk names. It also adds and modifies some test cases to demonstrate the new feature and fix some minor issues.Walkthrough
🤖 Generated by Copilot at 0564b81
name
field to the split chunks options and cache groups, and use it to assign names to the chunks based on the modules they contain (link, link, link, link, link, link)key
field to the cache groups, and use it to identify and merge modules that belong to the same cache group (link, link)ChunkNameGetter
type from aBox
to anArc
, and add a function to create an emptyChunkNameGetter
that returnsNone
(link, link)split-chunks-common/simple
that uses thename
field to create a single vendor chunk that contains thea.js
module (link, link, link, link)split-chunks/split-chunks-dot-name
that uses thename
field and cache groups to create a single chunk that contains thefoo.js
andfoo-2.js
modules, and does not treat the dot in the name as a separator (link, link, link, link)split-chunks/extract-css-to-single-chunk
test case (link)