Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot reading noEmitAssets #2942

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

faga295
Copy link
Contributor

@faga295 faga295 commented Apr 26, 2023

Related issue (if exists)

I fix it by always getting the first compiler's noEmitAssets

Summary

#2929

🤖 Generated by Copilot at 5897bda

Refactor server.ts to access noEmitAssets option from the first compiler and remove @ts-expect-error. This improves type safety and supports the new webpack feature.

Walkthrough

🤖 Generated by Copilot at 5897bda

  • Refactor code to access noEmitAssets option from first compiler and avoid @ts-expect-error (link)

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

🦋 Changeset detected

Latest commit: e7039ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@rspack/dev-server Patch
@rspack/cli Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/postcss-loader Patch
@rspack/dev-client Patch
@rspack/dev-middleware Patch
@rspack/plugin-html Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/core Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch
webpack-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@faga295 faga295 marked this pull request as ready for review April 26, 2023 05:09
@hyf0 hyf0 self-assigned this Apr 26, 2023
Copy link
Collaborator

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@hyf0 hyf0 added this pull request to the merge queue Apr 26, 2023
@hyf0 hyf0 changed the title fix: cannot reading no emit assets fix: cannot reading noEmitAssets Apr 26, 2023
Merged via the queue into web-infra-dev:main with commit cafa227 Apr 26, 2023
@github-actions github-actions bot mentioned this pull request May 9, 2023
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
* fix: multiCompiler on dev server

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants