Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@rspack/core): add typings about LoaderDefinition #2908

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

Asuka109
Copy link
Contributor

@Asuka109 Asuka109 commented Apr 24, 2023

Summary

🤖 Generated by Copilot at 10df027

This pull request enhances the loader system of @rspack/core by adding generic types and interfaces to the LoaderContext and loader definitions in packages/rspack/src/config/adapter-rule-use.ts. It also updates various test cases in webpack-test to use the new types and interfaces from the @rspack/core package instead of relative paths, improving code consistency and readability.

Walkthrough

🤖 Generated by Copilot at 10df027

@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2023

⚠️ No Changeset found

Latest commit: af9569e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hyf0 hyf0 self-assigned this Apr 24, 2023
@hardfist hardfist added this pull request to the merge queue Apr 24, 2023
Merged via the queue into main with commit 8ebae6f Apr 24, 2023
@hardfist hardfist deleted the feat/typing-loader-definition branch April 24, 2023 13:45
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants