New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: (#1297) 애널리틱스 로그 누락 #1298

Merged

KangTaeHoon merged 1 commit into develop from 1297-modify-analytics-log-condition

Sep 10, 2024

Contributor

KangTaeHoon commented Sep 10, 2024

💡 배경 및 개요

로그 누락

Resolves: #1297

📃 작업내용

타겟 조건문 수정

🙋‍♂️ 리뷰노트

x

✅ PR 체크리스트

이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. XCConfig, 노션, README)
이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "XCConfig 값 추가되었어요")
작업한 코드가 정상적으로 동작하나요?
Merge 대상 브랜치가 올바른가요?
PR과 관련 없는 작업이 있지는 않나요?

🎸 기타


          ✨ :: [#1297] 로그 분기 수정

db604d1

KangTaeHoon requested review from yongbeomkwak, kimdaehee0824, youn9k and baekteun as code owners

September 10, 2024 10:49

github-actions bot assigned KangTaeHoon

github-actions bot commented Sep 10, 2024 •

edited

Loading

❌ Error detected on SwiftLint

github-actions bot added the 1️⃣ Priority: High label

github-actions bot commented Sep 10, 2024

✅ 이슈와 PR의 Labels 동기화를 성공했어요!

yongbeomkwak approved these changes

View reviewed changes

KangTaeHoon merged commit afcb8e2 into develop

4 of 5 checks passed

KangTaeHoon deleted the 1297-modify-analytics-log-condition branch

September 10, 2024 11:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yongbeomkwak yongbeomkwak approved these changes

kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

youn9k Awaiting requested review from youn9k youn9k is a code owner

baekteun Awaiting requested review from baekteun baekteun is a code owner

Labels

1️⃣ Priority: High