Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#974) (보관함 > λ‚΄ 리슀트) μ• λ‹ˆλ©”μ΄μ…˜ μ΄ˆκΈ°ν™” κ³Όμ • μ•ˆλ³΄μ΄κ²Œ μˆ˜μ • #1282

Merged
merged 1 commit into from
Sep 1, 2024
Merged

πŸ”€ :: (#974) (보관함 > λ‚΄ 리슀트) μ• λ‹ˆλ©”μ΄μ…˜ μ΄ˆκΈ°ν™” κ³Όμ • μ•ˆλ³΄μ΄κ²Œ μˆ˜μ • #1282

merged 1 commit into from
Sep 1, 2024

Conversation

KangTaeHoon
Copy link
Contributor

@KangTaeHoon KangTaeHoon commented Sep 1, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

  • λ·°κ°€ λ‚˜νƒ€λ‚ λ•Œ μ• λ‹ˆλ©”μ΄μ…˜ μ΄ˆκΈ°ν™” 과정이 λˆˆμ— λ³΄μ—¬μ„œ 어색함

Resolves: #974

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • λ·°κ°€ λ‚˜νƒ€λ‚œ ν›„ μ• λ‹ˆλ©”μ΄μ…˜μ„ μ‹œμž‘ν•˜κ³ , λ·°κ°€ 사라진 ν›„ μ• λ‹ˆλ©”μ΄μ…˜μ„ μ΄ˆκΈ°ν™” μ‹œν‚΄

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

  • μ˜μƒμžˆλŠ”λ° μš©λŸ‰μ»€μ„œ μ•ˆμ˜¬λΌκ°...

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions github-actions bot added ✨ Feature 피쳐 개발 🐞 Bug 버그 κ΄€λ ¨ 3️⃣ Priority: Low μš°μ„ μˆœμœ„ ν•˜ labels Sep 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@KangTaeHoon

@KangTaeHoon KangTaeHoon changed the title πŸ”€ :: (#974) μ• λ‹ˆλ©”μ΄μ…˜ μ΄ˆκΈ°ν™” κ³Όμ • μ•ˆλ³΄μ΄κ²Œ μˆ˜μ • πŸ”€ :: (#974) (보관함 > λ‚΄ 리슀트) μ• λ‹ˆλ©”μ΄μ…˜ μ΄ˆκΈ°ν™” κ³Όμ • μ•ˆλ³΄μ΄κ²Œ μˆ˜μ • Sep 1, 2024
@KangTaeHoon KangTaeHoon merged commit 3efb477 into release/3.0.0 Sep 1, 2024
5 checks passed
@KangTaeHoon KangTaeHoon deleted the 974-complement-particle-ui-animate-in-storage branch September 1, 2024 11:58
@github-actions github-actions bot mentioned this pull request Sep 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youn9k youn9k youn9k approved these changes

@yongbeomkwak yongbeomkwak Awaiting requested review from yongbeomkwak yongbeomkwak is a code owner

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
3️⃣ Priority: Low μš°μ„ μˆœμœ„ ν•˜ 🐞 Bug 버그 κ΄€λ ¨ ✨ Feature 피쳐 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KangTaeHoon @youn9k