Addition: allow combobox role on button element #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #375 Allows `combobox` role on `button` element. [test case](https://w3c.github.io/html-aria/tests/button-combobox.html)
This was referenced Jan 15, 2022
scottaohara
added a commit
to scottaohara/WAI-ARIA-Usage
that referenced
this pull request
Jan 15, 2022
This PR addresses [ARIA in HTML](w3c/html-aria#396) being updated to allow the `combobox` role on these elements, and fix an oversight where `role=checkbox` should have been allowed on `input type=button` to match the same allowance on the `button` element.
scottaohara
added
the
Meets 2 implementations req
scottaohara
added
needs implementation commitment
stevefaulkner
approved these changes
Jan 16, 2022
scottaohara
added
Meets 2 implementations req
scottaohara
changed the title
scottaohara
added a commit
that referenced
this pull request
May 19, 2022
This was referenced Apr 17, 2024
pkra
pushed a commit
to w3c/aria
that referenced
this pull request
May 20, 2024
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label' related to w3c/html-aria#419 - w3c/html-aria#352 - w3c/html-aria#367 (and follow on [commit](w3c/html-aria@9cc2c0a)) - w3c/html-aria#360 - w3c/html-aria#353 - w3c/html-aria#372 - w3c/html-aria#402 - w3c/html-aria#404 - w3c/html-aria#403 - w3c/html-aria#396 - w3c/html-aria#391 - w3c/html-aria#369 - w3c/html-aria#381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #375
Allows
comboboxrole onbuttonelement andinput type=button.test case
This PR also corrects
input type=buttonmissing therole=checkbox, which is allowed on a<button>element.Need at least two checkers to accept this change before we can merge.
Preview | Diff