Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html-aam PR 538] Specify AXAPI behaviour for low, high, and optimum meter attributes #2339

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rahimabdi
Copy link
Contributor

Moved from w3c/html-aam#538

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit fe780cb
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/66ec865723e55200086f8cba
😎 Deploy Preview https://deploy-preview-2339--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rahimabdi
Copy link
Contributor Author

Re-assigning reviewers @rahimabdi @cookiecrook @jnurthen.

@@ -10958,7 +10958,10 @@ <h4 id="att-high">`high`</h4>
<tr>
<th><a href="https://developer.apple.com/reference/appkit/nsaccessibility">AX</a></th>
<td>
<div class="general">Not mapped</div>
<div class="general">
Expose "optimal value" via `AXValueDescription` if &lt;value&gt; is greater than or equal to &lt;high&gt;. Expose "suboptimal value" if &lt;value&gt; is less than &lt;high&gt; and
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahimabdi 's migrated comment:

Relevant WebKit code: https://github.com/WebKit/WebKit/blob/c330ea99229f6bb478dde74497ee652e44a3d7d5/Source/WebCore/html/HTMLMeterElement.cpp#L172

This looks correct for high. We'll also need to add the case for when the value is less than "low" (for which this is exposed as "critical value").

@@ -13090,7 +13096,7 @@ <h4 id="att-optimum">`optimum`</h4>
<tr>
<th><a href="https://developer.apple.com/reference/appkit/nsaccessibility">AX</a></th>
<td>
<div class="general">Not mapped</div>
<div class="general">Expose "optimal value" via `AXValueDescription` if &lt;value&gt; is greater than or equal to &lt;optimum&gt;.</div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahimabdi 's migrated comment:

Relevant WebKit code: https://github.com/WebKit/WebKit/blob/c330ea99229f6bb478dde74497ee652e44a3d7d5/Source/WebCore/html/HTMLMeterElement.cpp#L184

For optimum:

If value is greater than or equal to low AND value is less than or equal to high then value is "optimal value"
Else, value is "suboptimal value"
Note that in this case, there is no "critical value".

@@ -11911,7 +11914,10 @@ <h4 id="att-low">`low`</h4>
<tr>
<th><a href="https://developer.apple.com/reference/appkit/nsaccessibility">AX</a></th>
<td>
<div class="general">Not mapped</div>
<div class="general">
Expose "suboptial value" via `AXValueDescription` if &lt;value&gt; is greater than or equal to &lt;low&gt; and less than &lt;high&gt;. If &lt;value&gt; is less than &lt;low&gt;,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahimabdi's migrated comment:

Relevant WebKit code: https://github.com/WebKit/WebKit/blob/c330ea99229f6bb478dde74497ee652e44a3d7d5/Source/WebCore/html/HTMLMeterElement.cpp#L163

For low:

If value is less than or equal to low, then value is "optimal value"
if value is less than or equal to high (but greater than low), then value is "suboptimal value"
else, value is "critical value"
Also, looks like there is a typo for the word "suboptimal" here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant