Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update ESLint task globbing and autofix #655

Merged
merged 1 commit into from
May 23, 2018

Conversation

nschonni
Copy link
Contributor

Just noticed that the globbing that ESLint wasn't catching everything. There is already a .eslintigore file to exclude third party files that should be excluded.
Ran the fix target to apply the formatting after extending the glob pattern.

@nschonni
Copy link
Contributor Author

@mcking65 sorry this is going to be an ugly one to review. The github view with ?w=1 might be a little less noisy.
I believe all the changes outside of the package.json are:

  • Double quotes to single quote conversion. Looks like the --fix option just escapes internal double quotes after the external quote is changed to single
  • Indenting to 2 spaces
  • I manually had to fix a few hard tabs that It couldn't figure out. That might be preventable in the futrure by adding the whitespace configuration in the .eslintrc.json in addtion to the .editorconfig file
  • Few swaps from leading to trailing comma
  • Some spacing corrections around the function keyword

The only nice thing after this, is you shouldn't have to do another whitespace fixing PR here

@jnurthen
Copy link
Member

@nschonni I believe this is all coming from aria-common - https://github.com/w3c/aria-common

We do not modify these files in this repository as these are common files across all ARIA specs. As such they should be excluded from eslint in this repository.

@nschonni
Copy link
Contributor Author

OK, I'll add that to the ignore and rebase

examples/landmarks/js/visua11y.js
examples/landmarks/js/SkipTo.min.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knocked these out since they're already covered by the glob on the first line

@jnurthen jnurthen merged commit 648a01a into w3c:master May 23, 2018
@nschonni nschonni deleted the eslint-glob branch May 23, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants