Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Open in codepen" buttons to 6 more examples #1683

Merged
merged 7 commits into from
Jan 17, 2021
Merged

Add "Open in codepen" buttons to 6 more examples #1683

merged 7 commits into from
Jan 17, 2021

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Dec 15, 2020 •
edited
Loading

@spectranaut spectranaut changed the title Codepen implementation part6 Add "Open in codepen" buttons to 6 more examples Dec 15, 2020
carmacleod
carmacleod reviewed Dec 18, 2020
View reviewed changes
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 of 6 examples look good!

datepicker dialog example seems to be missing its CodePen button - maybe those changes weren't committed. :)

examples/grid/js/dataGrids.js Outdated Show resolved Hide resolved
@spectranaut
Copy link
Contributor Author

whoops! I forgot to write when I fixed the comment, I accidentally linked to datepicker INSTEAD of layout grid (or was it data grid?) -- so I updated that link @carmacleod !

@spectranaut
Copy link
Contributor Author

fixed the things you mentioned, take another look @carmacleod ? :)

@mcking65
Copy link
Contributor

@carmacleod all good now?

carmacleod
carmacleod approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcking65

@carmacleod all good now?

Yep, all good! Thanks again, @spectranaut !

@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern labels Dec 23, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Dec 23, 2020
mcking65
mcking65 requested changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have an accidental inclusion of some kind of temp working file.

q Outdated
@@ -0,0 +1,74 @@
diff --git a/examples/treegrid/js/treegrid-1.js b/examples/treegrid/js/treegrid-1.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this file is? Perhaps a working file accidentally included?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, sorry I missed that!
I see that it went in with the "Add Codepen button to data grids example" commit.
Since I had already reviewed the files for the 5 other examples, I jumped directly to the new data grids files to review them, so I missed seeing that sneaky extra file.
Nice catch, @mcking65 !

@spectranaut
Copy link
Contributor Author

fixed! good catch @mcking65

@spectranaut
Copy link
Contributor Author

Resolved conflicts!

mcking65
mcking65 approved these changes Jan 17, 2021
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @spectranaut!

@mcking65 mcking65 merged commit aea1acc into master Jan 17, 2021
@mcking65 mcking65 deleted the codepen-implementation-part6 branch January 18, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmacleod carmacleod carmacleod approved these changes

@mcking65 mcking65 mcking65 approved these changes

Assignees
No one assigned
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Milestone
1.2 Release 1
Development

Successfully merging this pull request may close these issues.
3 participants
@spectranaut @mcking65 @carmacleod