Add codepen to examples - part 2! #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression test coverage:Examples without any regression tests:
Examples missing some regression tests:
Example pages with Keyboard or Attribute table rows that do not have data-test-ids:
SUMMARY:55 example pages found. ERROR - missing tests: Please write missing tests for this report to pass. |
|
I made this branch on top of #1532, which I expect will land soon! |
carmacleod
approved these changes
Oct 30, 2020
spectranaut
force-pushed
the
codepen-implementation-part2
branch
from
2cb27c8
to
d6cb77e
Compare
carmacleod
reviewed
Oct 30, 2020
| <li>CSS: <a href="css/menuButtonAction.css" type="text/css">MenubuttonAction.css</a></li> | ||
| <li>Javascript: <a href="js/Menubutton2.js" type="text/javascript">Menubutton2.js</a></li> | ||
| <li>Javascript: <a href="js/Menubutton.js" type="text/javascript">Menubutton2.js</a></li> |
There was a problem hiding this comment.
Should change the link text as well, to match the href.
Suggested change
| <li>Javascript: <a href="js/Menubutton.js" type="text/javascript">Menubutton2.js</a></li> | |
| <li>Javascript: <a href="js/Menubutton.js" type="text/javascript">Menubutton.js</a></li> |
|
+1 for the 6 more examples! |
mcking65
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds codepen buttons to the following examples! To test locally, you will have to serve the example file with a web server (described here).
RawGitHack preview links