Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Add Prettier ESLint config #1553

Merged
merged 3 commits into from
Oct 21, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Oct 1, 2020

Related to #1180
Kept the the defaults, except for the quoting, that seems primarily single quotes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2020

Examples without any regression tests:

button/button_idl.html
dialog-modal/alertdialog.html


Examples missing some regression tests:

combobox/combobox-autocomplete-both.html:
    combobox-id
combobox/combobox-autocomplete-list.html:
    combobox-id
combobox/combobox-autocomplete-none.html:
    combobox-id
combobox/grid-combo.html:
    textbox-key-down-arrow
    textbox-key-up-arrow
dialog-modal/datepicker-dialog.html:
    textbox-aria-describedby
menu-button/menu-button-actions-active-descendant.html:
    menu-up-arrow
    menu-down-arrow
    menu-character
spinbutton/datepicker-spinbuttons.html:
    spinbutton-down-arrow
    spinbutton-up-arrow
    spinbutton-page-down
    spinbutton-page-up
    spinbutton-home
    spinbutton-end
toolbar/toolbar.html:
    toolbar-tab
    toolbar-right-arrow
    toolbar-left-arrow
    toolbar-home
    toolbar-end
    toolbar-toggle-esc
    toolbar-toggle-enter-or-space
    toolbar-radio-enter-or-space
    toolbar-radio-down-arrow
    toolbar-radio-up-arrow
    toolbar-button-enter-or-space
    toolbar-menubutton-enter-or-space-or-down-or-up
    toolbar-menu-enter-or-space
    toolbar-menu-down-arrow
    toolbar-menu-up-arrow
    toolbar-menu-escape
    toolbar-spinbutton-down-arrow
    toolbar-spinbutton-up-arrow
    toolbar-spinbutton-page-down
    toolbar-spinbutton-page-up
    toolbar-checkbox-space
    toolbar-link-enter-or-space
    toolbar-aria-controls
    toolbar-button-aria-pressed
    toolbar-button-aria-hidden
    toolbar-radiogroup-role
    toolbar-radiogroup-aria-label
    toolbar-radio-role
    toolbar-radio-aria-checked
    toolbar-radio-aria-hidden
    toolbar-button-aria-disabled
    toolbar-menubutton-aria-label
    toolbar-menubutton-aria-haspopup
    toolbar-menubutton-aria-controls
    toolbar-menubutton-aria-expanded
    toolbar-menu-role
    toolbar-menu-aria-label
    toolbar-menuitemradio-role
    toolbar-menuitemradio-aria-checked
    toolbar-menuitemradio-tabindex
    toolbar-spinbutton-role
    toolbar-spinbutton-aria-label
    toolbar-spinbutton-aria-valuenow
    toolbar-spinbutton-aria-valuetext
    toolbar-spinbutton-aria-valuemin
    toolbar-spinbutton-aria-valuemax


Examples documentation table rows without data-test-ids:

dialog-modal/alertdialog.html
    "Keyboard Support" table(s):
       Tab
       Shift + Tab
       Escape
       Command + S
       Control + S
    "Attributes" table(s):
       alertdialog
       aria-labelledby=IDREF
       aria-describedby=IDREF
       aria-modal=true
       alert

SUMMARTY:

  55 example pages found.
  2 example pages have no regression tests.
  8 example pages are missing approximately 61 out of approximately 775 tests.

ERROR - missing tests:

  Please write missing tests for this report to pass.

.prettierrc Outdated
@@ -0,0 +1,3 @@
{
"singleQuote": true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to be the more common pattern so I used this over the default double quote

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great too!

After this merges @jongund, npm run lint:es will fail on a lot more things related to coding style -- but you can fix all of these failures by running npm run fix. It will break long lines up into multiple lines and switch double quotes with single quotes and other things like this. You will probably have to run npm run fix on all your open PRs once this merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants