Update title and footers in example pages to 1.2 (issue #1225) #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 25, 2019 12:33
ZoeBijl
approved these changes
Oct 25, 2019
examples/coding-template/Depricated-MultipleImplementationExample-Template.html
Show resolved
Hide resolved
|
@ZoeBijl, thank you for the thorough review! |
1 task
ZoeBijl
changed the title
michael-n-cooper
pushed a commit
that referenced
this pull request
Oct 29, 2019
All Example pages: Change APG version from 1.1 to 1.2 (pull #1226) Resolves #1225 with the following changes: * Fix source formatting in a few example page title and footer nav elements * breadcrumb example: remove reference to 1.1 in relative file path * Change to relative url in toolbar/help.html * Update aria practices version in example code templates * Update every example page title and footer to 1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To explain the several commits:
In order to be able to change all of the references in one
sed, I fixed some example file's formatting for the title and footers in separate commits for disclosure example pages and combobox example pages.There were a few relative links with link text that said "WAI-ARIA Authoring Practices 1.1", so I removed the "1.1" in order for the links to not be wrong when looking at the editors draft. This is in the "toolbar" and "breadcrumbs" commits.
I also updated the reference table template, but examples/index.html is still out of date.