Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Rename both controller variables in Handle Fetch algorithm. #1705

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

mkruisselbrink
Copy link
Collaborator

@mkruisselbrink mkruisselbrink commented Feb 15, 2024

To make it clearer which controller is which, rename them to fetchController and abortController respectively.


Preview | Diff

@mkruisselbrink
Copy link
Collaborator Author

@shaseley can you PTAL?

@shaseley
Copy link
Contributor

LGTM. Much clearer; thanks!

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, looks great.

@annevk
Copy link
Member

annevk commented Mar 6, 2024

Unfortunately it needs rebasing.

To make it clearer which controller is which, rename them to
fetchController and abortController respectively.
@mkruisselbrink mkruisselbrink merged commit 5408e2e into main Apr 30, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Apr 30, 2024
…hm. (#1705)

SHA: 5408e2e
Reason: push, by mkruisselbrink

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to asleekgeek/ServiceWorker that referenced this pull request May 1, 2024
…hm. (w3c#1705)

SHA: 5408e2e
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@annevk annevk deleted the fix-double-controller-thing branch May 2, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants