bpo-29655: Fixed possible reference leaks in import *. (python#301)

Patch by Matthias Bussonnier.
w1y2l32009 · Feb 26, 2017 · 160edb4 · 160edb4
1 parent 53c1892
commit 160edb4
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/Python/ceval.c b/Python/ceval.c
@@ -2810,13 +2810,16 @@ _PyEval_EvalFrameDefault(PyFrameObject *f, int throwflag)
         TARGET(IMPORT_STAR) {
             PyObject *from = POP(), *locals;
             int err;
-            if (PyFrame_FastToLocalsWithError(f) < 0)
+            if (PyFrame_FastToLocalsWithError(f) < 0) {
+                Py_DECREF(from);
                 goto error;
+            }
 
             locals = f->f_locals;
             if (locals == NULL) {
                 PyErr_SetString(PyExc_SystemError,
                     "no locals found during 'import *'");
+                Py_DECREF(from);
                 goto error;
             }
             err = import_all_from(locals, from);