Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: whitespace: 'condense' should honor <pre> tag as well #9660

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

Justineo
Copy link
Member

@Justineo Justineo commented Mar 9, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@Justineo Justineo changed the title Fix: whitespace: 'condense' should honor <pre> tag as well fix: whitespace: 'condense' should honor <pre> tag as well Mar 9, 2019
expect(pre.children[0].text).toBe('abc')
const text = ast.children[1]
expect(text.type).toBe(3)
expect(text.text).toBe(' def')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added cases are copied from earlier parts except for this line. The \n part should be collapsed into here.

@yyx990803 yyx990803 merged commit f1bdd7f into vuejs:dev Mar 14, 2019
@Justineo Justineo deleted the fix-pre-condense branch March 14, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants