Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pwa plugin: allow to define cacheId to prevent 'not allowed error' #891

Closed
mutefiRe opened this issue Feb 27, 2018 · 2 comments · Fixed by #939
Closed

pwa plugin: allow to define cacheId to prevent 'not allowed error' #891

mutefiRe opened this issue Feb 27, 2018 · 2 comments · Fixed by #939
Labels
contribution welcome feature request intend to implement The team has the intention to implement this feature at some point. Contribution is also welcome.

Comments

@mutefiRe
Copy link

mutefiRe commented Feb 27, 2018 •
edited
Loading

What problem does this feature solve?

I'm having trouble with the pwa plugin for 3.0. I want to use InjectManifest, but building the project doesn't work because cacheId is not allowed for workbox 3 in InjectManifest Mode. But cacheId is always set by cli-plugin-pwa/index.js, no matter which mode is set.
Error message: ERROR ValidationError: "cacheId" is not a supported parameter.

What does the proposed API look like?

Allow setting CacheId in vue.config.js and also add the possibilty to use null as value, which causes cli-plugin-pwa/index.js to remove the attribute, to prevent this error.
@mutefiRe mutefiRe changed the title pwa plugin: allow users to define cacheId to prevent 'not allowed error' pwa plugin: allow to define cacheId to prevent 'not allowed error' Feb 27, 2018
@yyx990803 yyx990803 added feature request contribution welcome intend to implement The team has the intention to implement this feature at some point. Contribution is also welcome. labels Feb 28, 2018
@umarov umarov mentioned this issue Mar 4, 2018
Merged
@umarov
Copy link
Contributor

umarov commented Mar 4, 2018

I stumbled upon this issue as well and submitted a PR #939.

yyx990803 pushed a commit that referenced this issue Mar 4, 2018
@umarov @yyx990803
fix(pwa): set cacheid in GenerateSW mode only (#939)
43971d8 
close #891
@mutefiRe
Copy link
Author

mutefiRe commented Mar 4, 2018

Very nice, thanks 😉

@snyk-bot snyk-bot mentioned this issue Jan 22, 2020
Open
@snyk-bot snyk-bot mentioned this issue Dec 29, 2020
Open
This was referenced Sep 15, 2021
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Jan 10, 2023
Open
@posrix posrix mentioned this issue May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome feature request intend to implement The team has the intention to implement this feature at some point. Contribution is also welcome.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli-plugin-pwa): Set cacheid in GenerateSW mode only umarov/vue-cli
3 participants
@yyx990803 @umarov @mutefiRe