Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api.render leaves the rendered file ending if new version is shorter #2275

Closed
jacekkarczmarczyk opened this issue Aug 19, 2018 · 0 comments · Fixed by #2341
Closed

api.render leaves the rendered file ending if new version is shorter #2275

jacekkarczmarczyk opened this issue Aug 19, 2018 · 0 comments · Fixed by #2341
Assignees
@haoqunjiang

Comments

@jacekkarczmarczyk
Copy link

jacekkarczmarczyk commented Aug 19, 2018 •
edited
Loading

Version

3.0.0

Reproduction link

https://github.com/jacekkarczmarczyk/vue-cli-plugin-render-bug

Template content:

<%_ if (long) { _%>
AAAAA
<%_ } else { _%>
BB
<%_ } _%>

Node and OS info

yarn, node 8.13, windows

Steps to reproduce

git clone [email protected]:jacekkarczmarczyk/vue-cli-plugin-render-bug.git
vue create render-bug
cd render-bug
yarn add ../vue-cli-plugin-render-bug

# Select "yes" in the first prompt
vue invoke render-bug

# Select "No" in the first prompt
vue invoke render-bug

What is expected?

./src/plugin.js content should be:

BB

What is actually happening?

./src/plugin.js content is:

BB
AA
@haoqunjiang haoqunjiang self-assigned this Aug 21, 2018
haoqunjiang added a commit to haoqunjiang/vue-cli that referenced this issue Aug 23, 2018
@haoqunjiang
fix: use sync fs methods in writeFileTree
f034564 
closes vuejs#2275

Iterating over async functions would put too many write calls in I/O
queue in the same time, leading to weird bugs.
@haoqunjiang haoqunjiang mentioned this issue Aug 23, 2018
Merged
haoqunjiang added a commit that referenced this issue Sep 3, 2018
@haoqunjiang
fix: use sync fs methods in writeFileTree (#2341)
ba15fa2 
closes #2275

Iterating over async functions would put too many write calls in I/O
queue in the same time, leading to weird bugs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haoqunjiang haoqunjiang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use sync fs methods in writeFileTree haoqunjiang/vue-cli
2 participants
@haoqunjiang @jacekkarczmarczyk