Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-page template fallback differs from doc #1679

Closed
MarvinXu opened this issue Jun 26, 2018 · 3 comments · Fixed by #1707
Closed

multi-page template fallback differs from doc #1679

MarvinXu opened this issue Jun 26, 2018 · 3 comments · Fixed by #1707

Comments

@MarvinXu
Copy link
Contributor

Version

3.0.0-rc.3

Reproduction link

https://github.com/MarvinXu/vue-cli-mpa-test

Steps to reproduce

vue inspect > out.js

see this fragment:

// out.js

/* config.plugin('html-subpage') */
    new HtmlWebpackPlugin(
      {
        templateParameters: function () { /* omitted long function */ },
        chunks: [
          'chunk-vendors',
          'chunk-common',
          'subpage'
        ],
        template: 'E:\\workspace2018\\vue-cli-mpa-test\\node_modules\\@vue\\cli-service\\lib\\config\\index-default.html',
        filename: 'subpage.html'
      }
    )

What is expected?

https://cli.vuejs.org/config/#pages

"when using the entry-only string format, template is inferred to be public/subpage.html and falls back to public/index.html if not found."

What is actually happening?

subpage's template did not fall back to 'public/index.html' but some other default template in node_modules.

MarvinXu pushed a commit to MarvinXu/vue-cli that referenced this issue Jun 26, 2018
@MarvinXu
Copy link
Contributor Author

I'll try make a PR for this.

MarvinXu added a commit to MarvinXu/vue-cli that referenced this issue Jun 26, 2018
@MarvinXu
Copy link
Contributor Author

@Akryum I see you added docs label. Are you going to modify the doc or should I make a PR to fix this?

@Akryum
Copy link
Member

Akryum commented Jun 29, 2018

You can. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants