Fix lastUpdated to work w/ Git submodules
#2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach was broken as `git log` does not deliver data if called with a path that leads inside a submodule. The fix is to set the file's dirname as `cwd` and call git w/ just the file name. This works in all circumstances.
3 tasks
chgeo
changed the title
lastUpdated to work w/ Git submodules
chgeo
commented
Mar 27, 2023
brc-dd
reviewed
Mar 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach was broken as
git logdoes not deliver data if called with a path that leads inside a submodule.The fix is to set the file's dirname as
cwdand call git w/ just the file name. This works in all circumstances.Fixes #2148