Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select labelInValue validator prop type error #1393

Conversation

sendya
Copy link
Member

@sendya sendya commented Nov 7, 2019

thank you for your contribution! 😄

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

https://codesandbox.io/s/vue-antd-template-765lf

fix selectLabelInValue validator PropsType

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify
Copy link

netlify bot commented Nov 7, 2019

Deploy preview for ant-desing-vue processing.

Building with commit 53e5a39

https://app.netlify.com/sites/ant-desing-vue/deploys/5dc3dce387651c000c49e420

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #1393 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1393   +/-   ##
=======================================
  Coverage   87.88%   87.88%           
=======================================
  Files         156      156           
  Lines        5392     5392           
  Branches     1521     1521           
=======================================
  Hits         4739     4739           
  Misses        583      583           
  Partials       70       70
Impacted Files Coverage Δ
components/select/index.jsx 93.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094f032...53e5a39. Read the comment docs.

@tangjinzhou tangjinzhou merged commit d8ac932 into vueComponent:master Nov 8, 2019
@github-actions
Copy link

github-actions bot commented Nov 8, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants