Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From 组件新增 labelCol、wrapperCol 并优化了 Radio Group的竖线 #1365

Merged
merged 4 commits into from
Nov 15, 2019
Merged

Conversation

PanStar
Copy link
Contributor

@PanStar PanStar commented Oct 31, 2019

首先,感谢你的贡献! 😄

新特性请提交至 feature 分支,其余可提交至 master 分支。在一个维护者审核通过后合并。请确保填写以下 pull request 的信息,谢谢!~

[English Template / 英文模板]

这个变动的性质是

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 组件样式改进
  • TypeScript 定义更新
  • 重构
  • 代码风格优化
  • 分支合并
  • 其他改动(是关于什么的改动?)

需求背景

  1. 描述相关需求的来源。
  2. 要解决的问题。
  3. 相关的 issue 讨论链接。

需求场景:Form中每个FormItem都需要绑定 labelCol、wrapperCol
issues:issues#450

实现方案和 API(非新功能可选)

  1. 基本的解决思路和其他可选方案。
  2. 列出最终的 API 实现和用法。
  3. 涉及 UI/交互变动需要有截图或 GIF。

解决思路:支持在Form最外层绑定 labelCol、wrapperCol,若FormItem未绑定则用最外层的配置

对用户的影响和可能的风险(非新功能可选)

  1. 这个改动对用户端是否有影响?影响的方面有哪些?
  2. 是否有可能隐含的 break change 和其他风险?

Changelog 描述(非新功能可选)

  1. 英文描述
  2. 中文描述(可选)

请求合并前的自查清单

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

后续计划(非新功能可选)

如果这个提交后面还有相关的其他提交和跟进信息,可以写在这里。

05948f 补充了ts 并优化了一个Radio的样式问题

需求场景: QQ浏览器中Radio Group 样式问题,在Chrome中拖动浏览器大小也能重现
issues: issues#1378

解决思路:删除了Radio的多余样式

@netlify
Copy link

netlify bot commented Oct 31, 2019

Deploy preview for ant-desing-vue processing.

Building with commit 05948fc

https://app.netlify.com/sites/ant-desing-vue/deploys/5dba746ae7c68f000835943a

@PanStar PanStar changed the title 1.4.3 dev From 组件新增 labelCol、wrapperCol Oct 31, 2019
@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #1365 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1365      +/-   ##
==========================================
+ Coverage   87.89%   87.89%   +<.01%     
==========================================
  Files         156      156              
  Lines        5393     5395       +2     
  Branches     1521     1523       +2     
==========================================
+ Hits         4740     4742       +2     
  Misses        583      583              
  Partials       70       70
Impacted Files Coverage Δ
components/form/Form.jsx 55.55% <ø> (ø) ⬆️
components/form/FormItem.jsx 86.44% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b66db...05948fc. Read the comment docs.

2 Button 组件 文档优化
3 Radio 组件 样式优化
@PanStar PanStar changed the title From 组件新增 labelCol、wrapperCol From 组件新增 labelCol、wrapperCol 并优化了 Radio Group的竖线 Nov 4, 2019
@sendya
Copy link
Member

sendya commented Nov 14, 2019

需求场景: QQ浏览器中Radio Group 样式问题,在Chrome中拖动浏览器大小也能重现
issues: issues#1378

我也没复现这个问题

@tangjinzhou tangjinzhou merged commit ae6aee6 into vueComponent:master Nov 15, 2019
@PanStar PanStar deleted the 1.4.3_dev branch November 28, 2019 07:05
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants