Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select add maxTagTextLength prop #1217

Merged
merged 2 commits into from
Sep 23, 2019

Conversation

zkwolf
Copy link
Member

@zkwolf zkwolf commented Sep 20, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
    用于指定多选时tag标签的最大文本长度,超出的文本会用...进行隐藏
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify
Copy link

netlify bot commented Sep 20, 2019

Deploy preview for ant-desing-vue processing.

Building with commit cddfbeb

https://app.netlify.com/sites/ant-desing-vue/deploys/5d84a701eeabde000856e809

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #1217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1217   +/-   ##
======================================
  Coverage    87.1%   87.1%           
======================================
  Files         146     146           
  Lines        4847    4847           
  Branches     1453    1453           
======================================
  Hits         4222    4222           
  Misses        558     558           
  Partials       67      67
Impacted Files Coverage Δ
components/select/index.jsx 92.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9107da...cddfbeb. Read the comment docs.

@tangjinzhou tangjinzhou changed the title feat: select add maxTagTextLenth prop feat: select add maxTagTextLength prop Sep 20, 2019
@tangjinzhou
Copy link
Member

ts 类型文件也可以补充下

@tangjinzhou tangjinzhou merged commit f3d0e23 into vueComponent:master Sep 23, 2019
@zkwolf zkwolf deleted the feat-select-maxTagTextLength branch September 23, 2019 04:29
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants