AvatarBuilder.BuildHumanAvatar には隠れたボーン名 HumanTrait.BoneName が必用 #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HumanBodyBones.ToString != HumanTrait.BoneName であることに注意(指のみ。Space)
notargs
previously approved these changes
Sep 15, 2022
| cashedHumanTraitBoneName[i] = boneNames[i].Replace(" ", ""); | ||
| } | ||
| } | ||
| // HumanTrait.BoneName 呼び出し毎にGCが発生 |
|
コメント増量。 |
ousttrue
commented
Sep 15, 2022
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| namespace UniHumanoid | |||
| { | |||
| // TODO: BoneLimit.cs に分ける(v0.104以降) | |||
There was a problem hiding this comment.
diff が分かりにくくなるので、あとで
ousttrue
commented
Sep 15, 2022
| // * HumanTrait.BoneName | ||
| // * traitName.Replace | ||
| // * Enum.Parse | ||
| // |
There was a problem hiding this comment.
HumanTrait.BoneName が問題の根源
ousttrue
commented
Sep 15, 2022
| traitName => (HumanBodyBones)Enum.Parse(typeof(HumanBodyBones), traitName.Replace(" ", "")), | ||
| traitName => traitName); | ||
|
|
||
| // 逆引き |
There was a problem hiding this comment.
Enum.Parse がGC出ると書いた手前、逆引きもキャッシュすることにした
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #1799
HumanBodyBones.ToString != HumanTrait.BoneName であることに注意(指のみ。Space)。
分かりにくいので変数名、関数名をくどい感じにしました。
コード整理したら
HumanBodyBones=>HumanTrait.BoneNameになった。要するに
Dictionary<HumanBodyBones, string>