Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Galata tests, update the reference screenshot #934

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 1, 2021

References

This should fix some of the recent failing CI checks.

Code changes

Update reference screenshot in the UI tests.

User-facing changes

None

Backwards-incompatible changes

None

@jtpio jtpio added this to the 0.2.x milestone Sep 1, 2021
@jtpio jtpio marked this pull request as draft September 1, 2021 06:44
@jtpio jtpio marked this pull request as ready for review September 1, 2021 08:09
@jtpio jtpio changed the title Update reference screenshot for Galata tests Improve Galata tests, update the reference screenshot Sep 1, 2021
@jtpio
Copy link
Member Author

jtpio commented Sep 1, 2021

The UI test check on CI now seems to be more robust after a couple of restarts.

@jtpio
Copy link
Member Author

jtpio commented Sep 1, 2021

Merging since this should also help with the other open PRs.

@jtpio jtpio merged commit 47cdccd into voila-dashboards:master Sep 1, 2021
@jtpio jtpio deleted the update-galata branch September 1, 2021 09:07
This was referenced Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant