Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to jsdeliver for the CDN #830

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Switch to jsdeliver for the CDN #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/voila/src/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* The full license is in the file LICENSE, distributed with this software. *
****************************************************************************/

const cdn = 'https://unpkg.com/';
const cdn = 'https://cdn.jsdelivr.net/npm/';

/**
* Load a package using requirejs and return a promise
Expand Down Expand Up @@ -50,7 +50,7 @@ function moduleNameToCDNUrl(moduleName: string, moduleVersion: string) {
* @param moduleName The name of the module to load..
* @param version The semver range for the module, if loaded from a CDN.
*
* By default, the CDN service used is unpkg.com. However, this default can be
* By default, the CDN service used is cdn.jsdelivr.net. However, this default can be
* overriden by specifying another URL via the HTML attribute
* "data-jupyter-widgets-cdn" on a script tag of the page.
*
Expand Down
2 changes: 1 addition & 1 deletion share/jupyter/voila/templates/base/page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
{% block stylesheets %}
{% endblock %}

<link rel="stylesheet" href="https://unpkg.com/[email protected]/css/font-awesome.min.css" type="text/css" />
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/css/font-awesome.min.css" type="text/css" />

{% block meta %}
{% endblock %}
Expand Down
2 changes: 1 addition & 1 deletion share/jupyter/voila/templates/classic/index.html.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
display: none;
}
</style>
<link rel="stylesheet" href="https://unpkg.com/[email protected]/css/font-awesome.min.css" type="text/css" />
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/css/font-awesome.min.css" type="text/css" />
{{ super() }}
{%- endblock html_head_css -%}

Expand Down
2 changes: 1 addition & 1 deletion share/jupyter/voila/templates/lab/index.html.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
{%- endblock html_head_js -%}

{%- block html_head_css -%}
<link rel="stylesheet" href="https://unpkg.com/[email protected]/css/font-awesome.min.css" type="text/css" />
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/css/font-awesome.min.css" type="text/css" />
{{ super() }}
{{ spinner.css() }}
<style>
Expand Down