Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and extend tests / expose and fix template bug #81

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Refactor and extend tests / expose and fix template bug #81

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0014a5c
refactor and extend tests
maartenbreddels Mar 14, 2019
0d88a12
collect_template_paths was called in handler, causing template argume…
maartenbreddels Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
collect_template_paths was called in handler, causing template argume… 
…nt to have no effect
  • Loading branch information
@maartenbreddels
maartenbreddels committed Mar 14, 2019
commit 0d88a12c8ed9ca42c6e33fff5986c43789f11dfe
9 changes: 0 additions & 9 deletions voila/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
from nbconvert.preprocessors.execute import executenb
from nbconvert import HTMLExporter

from .paths import collect_template_paths


class VoilaHandler(JupyterHandler):

Expand All @@ -25,13 +23,6 @@ def initialize(self, **kwargs):
self.nbconvert_template_paths = kwargs.pop('nbconvert_template_paths', [])
self.exporter_config = kwargs.pop('config', None)

collect_template_paths(
self.nbconvert_template_paths,
[], # static_paths,
[], # tornado templates,
'default'
)

@tornado.web.authenticated
@tornado.gen.coroutine
def get(self, path=None):
Expand Down