Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #624 - Broken link in docs #656

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Fix #624 - Broken link in docs #656

merged 1 commit into from
Jul 28, 2020

Conversation

mourarthur
Copy link
Contributor

I was reading the template documentation and noticed a dead link.
This was already documented back in may, as per #624: "if you click 'check out the nbconvert basic HTML template' you'll get a 404."
From what I could gather, the target files were moved in jupyter/nbconvert@f4c7dae

The response to the issue suggested the need for a broader update to the documentation "to reflect the template refactoring that we just merged", but in the meantime at least the link is fixed.

As per #624: "if you click 'check out the nbconvert basic HTML template' you'll get a 404."
From what I could gather, the files were moved in jupyter/nbconvert@f4c7dae
@SylvainCorlay
Copy link
Member

Good catch thanks!

@SylvainCorlay SylvainCorlay merged commit 1655821 into voila-dashboards:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants