-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use async_start_new_kernel_client from nbclient #597
Use async_start_new_kernel_client from nbclient #597
Conversation
Trigger CI. |
Not sure why |
This probably: |
Trigger CI. |
Rebased. |
@@ -46,7 +46,7 @@ var voila_process = function(cell_index, cell_count) { | |||
Therefore it is important to have the cell loop in the template. | |||
The issue for Jinja is: https://github.com/pallets/jinja/issues/1044 | |||
#} | |||
{%- for cell in cell_generator(nb, kernel_id) -%} | |||
{%- for cell in cell_generator(nb) -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we don't need the kernel id in the jupyter-config-data?
I recall there was a comment by @maartenbreddels about this, but don't remember what.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jupyter-config-data
gets the kernel_id
from kernel_start()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deja vu feeling here :), I think it was a different PR. We do need the kernel_id, otherwise, we break the API, and we lose flexibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Let's merge this PR. |
Once nbclient 0.3.0 is released this will be ready to be merged.