-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean templates #415
Clean templates #415
Conversation
0313694
to
a875452
Compare
a875452
to
768ba51
Compare
Putting this in WIP, we need to check if this login_widget is for the authentication when the token is not in the url |
👍 This |
It seems to me that those login/logout widgets are leftovers... When you browse Voila without the token you get redirected to And the issue you pointed to @jtpio is comforting me in thinking those widgets are useless. cc. @maartenbreddels |
Also, there does not seem to be JavaScript code inserted in the page that gives behavior to those buttons |
|
That was my impression too. |
So, are you ok with this @maartenbreddels ? |
Yeah, I'm a bit unsure about the login/logout stuff. I'm not so familiar with it, don't know if it functions at all, and I wonder if people already depend on it. @timkpaine : you might be using the login/logout features, is it functional at all? If it does not function, I'm ok with this PR. |
@maartenbreddels you added this |
There was a lot of unwanted noise in those templates like the "login widget". I suppose it was due to a copy/paste from JupyterLab/Notebook templates.
I also improved the code indentation.