Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean templates #415

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Conversation

martinRenou
Copy link
Member

There was a lot of unwanted noise in those templates like the "login widget". I suppose it was due to a copy/paste from JupyterLab/Notebook templates.

I also improved the code indentation.

@martinRenou martinRenou changed the title Clean templates WIP - Clean templates Oct 11, 2019
@martinRenou
Copy link
Member Author

Putting this in WIP, we need to check if this login_widget is for the authentication when the token is not in the url

@jtpio
Copy link
Member

jtpio commented Oct 11, 2019

Putting this in WIP, we need to check if this login_widget is for the authentication when the token is not in the url

👍

This login_widget was also indirectly mentioned in #260 I believe.

@martinRenou
Copy link
Member Author

martinRenou commented Oct 14, 2019

It seems to me that those login/logout widgets are leftovers...

When you browse Voila without the token you get redirected to http://localhost:8888/login?next=%2Fvoila, so it is not handled by Voila.

And the issue you pointed to @jtpio is comforting me in thinking those widgets are useless.

cc. @maartenbreddels

@martinRenou martinRenou changed the title WIP - Clean templates Clean templates Oct 14, 2019
@martinRenou
Copy link
Member Author

Also, there does not seem to be JavaScript code inserted in the page that gives behavior to those buttons

@maartenbreddels
Copy link
Member

maartenbreddels commented Oct 14, 2019

What is page.html actually? Is that the classic notebook template? If so, we can remove it I guess. It is the main template for all the others :)

@jtpio
Copy link
Member

jtpio commented Oct 14, 2019

It seems to me that those login/logout widgets are leftovers...

That was my impression too.

@martinRenou
Copy link
Member Author

So, are you ok with this @maartenbreddels ?

@maartenbreddels
Copy link
Member

Yeah, I'm a bit unsure about the login/logout stuff. I'm not so familiar with it, don't know if it functions at all, and I wonder if people already depend on it.

@timkpaine : you might be using the login/logout features, is it functional at all?

If it does not function, I'm ok with this PR.

@martinRenou
Copy link
Member Author

@maartenbreddels you added this login_widget part. 28faacc. Was it some copy-paste from somewhere else?

@SylvainCorlay SylvainCorlay merged commit 590dd58 into voila-dashboards:master Oct 17, 2019
@martinRenou martinRenou deleted the clean_templates branch October 17, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants