-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Voila logo for the spinner #393
Use Voila logo for the spinner #393
Conversation
martinRenou
commented
Oct 2, 2019
That looks nice. Maybe we want to minify / compress the svg file too ? |
We can try, but it looks pretty small already |
This is really cool! The improvement of the spinner SVG should probably be in a different PR. (Removing the green circle under the yellow will remove the rendering artifact) |
A way to prevent the loading delay may be to inline the SVG in the XML. |
One simple change to make that will reduce the size would be
|
Inkscape has an option to save as "Optimized SVG (*.svg)", which should take care of all these. |
cc22ebc
to
d34b772
Compare
I also removed unused defined colors, whitespaces and new lines, saving ~100kb |
Does this affect the perceived loading delay? |
share/jupyter/voila/templates/default/nbconvert_templates/voila.tpl
Outdated
Show resolved
Hide resolved
d34b772
to
f5e7df4
Compare
It does actually, the logo arrived the same time as the text when I tried. But it's only local... |
The way to fix this is to inline the svg in the HTML. This will also make it possible to set the colors of the parts of the spinner with CSS. |
share/jupyter/voila/templates/default/nbconvert_templates/voila.tpl
Outdated
Show resolved
Hide resolved
7877550
to
7e4a648
Compare
This looks great and I am happy to get this in as it is now. |
Some CSS fixes coming |
Anything more to add / fix before merging it? (so it can go in the next release) |
We should credit Jasmine for her contribution! |
Perfect, especially inlining the svg indeed, that should render instantly. |
37385b9
to
c6e4d17
Compare
@jasminefrh I added your contribution :) Thanks a lot for your help! |