Monochrome voila icon for the notebook toolbar #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeing the same failure on the same setup (osx py37) in other PR's, not sure if it is a fluke (the timeout limit too small) or consistent failures. |
|
Yes I've seen those too. Restarted the job and it passed. |
|
Ok, good to know, so we should fix that. Do you want me to take a look at it? |
|
Sure. A first guess for now is that it could be related to the way kernels are shut down ( |
|
@maartenbreddels I think this is ready for review / merge |
|
Work here 👍 |
|
Looks all great. Merging. We will update things when we adopt the new design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grey and orange default icon wouldn't render nice when using the Dark theme.
Switching to light and dark monochrome icons that follow the style of the existing Toolbar items.