Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tornado templates #291

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Fix tornado templates #291

merged 1 commit into from
Jul 8, 2019

Conversation

SylvainCorlay
Copy link
Member

No description provided.

@jtpio
Copy link
Member

jtpio commented Jul 8, 2019

For this template file require.js was actually not even loaded.

Follow-up for #288, #287 and #290

@SylvainCorlay
Copy link
Member Author

@jtpio yes I think there were warnings about require. Feel free to merge.

@jtpio
Copy link
Member

jtpio commented Jul 8, 2019

Will do once the tests are done 👍

@jtpio jtpio merged commit 84c6d01 into voila-dashboards:master Jul 8, 2019
@SylvainCorlay SylvainCorlay deleted the fixup-tornado-templates branch July 8, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SylvainCorlay @jtpio