-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Heroku deploy instructions #1037
Conversation
The current Python runtime is not valid. I've: - Updated the Python runtime - Added a link to Heroku's docs on Python runtimes so if/when the new runtime becomes invalid, it is easy to find the updated one
|
||
3. Add a file named Procfile to the project directory with the | ||
following content if you want to show all notebooks: | ||
|
||
.. code:: text | ||
|
||
web: voila —-port=$PORT --no-browser | ||
web: voila --port=$PORT --no-browser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced this character (and throughout the file) as it was a Unicode character (I believe an em dash).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
RTD build passes and other CI failures are not related. |
Ah looks like this was targeting the @meeseeksdev please backport to main |
…7-on-main Backport PR #1037 on branch main (Updating Heroku deploy instructions)
In addition to replacing a Unicode character with it's ascii replacement, I've also updated the Python runtime as the one listed is no longer valid. Specifically, I've:
I chose not to use the latest runtime (
3.10.0
) as I'm not sure that (based on #1027) that voila supports Python 3.10.x yet.