This repository has been archived by the owner on Mar 15, 2022. It is now read-only.
Added rockset sink support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @timothysc PTAL |
|
@foxish I'd highly recommend possibly refactor in your rocketset client library if making such a small change has such a large vendor/import change. Please squash then lgtm from me. |
Signed-off-by: Rui Aguiar <[email protected]> added workspace and vendor folder Signed-off-by: Rui Aguiar <[email protected]> fixed import Signed-off-by: Rui Aguiar <[email protected]> updated config to have rockset workspace Signed-off-by: Rui Aguiar <[email protected]> took out print statments Signed-off-by: Rui Aguiar <[email protected]>
|
@timothysc squashed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rockset sink to store events data in rockset.
Serializes events to JSON and uses the rockset go client to write to a specified rockset collection and workspace. Also contains a test case for manual verification of event uploading.
Signed-off-by: Rui Aguiar [email protected]