Azure Event Hubs Sink #73
Conversation
|
@juan-lee - could you please sign off on your commit. Also, that is an enormous vendor chain for a sink. |
juan-lee
force-pushed
the
eventhub
branch
2 times, most recently
from
dad0595
to
59a9ce7
Compare
|
@timothysc I added the signed off by. How can I get re-run the check? |
|
@juan-lee Only the last commit is signed; all the commits on the PR need signed. Personally I typically squash to a single commit and then sign that. That is probably the right thing to do here since originally your PR was using |
|
Thank you @johnSchnake! |
|
@timothysc @johnSchnake is there anything else you need from me to get this PR merged? |
|
Another PR just merged, I'll update this branch onto master via the web UI if you want or you can rebase again. I wish there were less dependencies here but I personally don't have an azure account setup to test this, have you verified it works as expected? I can build and run the basic command (from the README) and things continue to work well. Can you provide some feedback/screenshots/logs of events working with the new eventhub? |
|
Thanks @johnSchnake I'll take a look to see if I can trim down the dependencies. Unfortunately, It's probably all being pulled in by the azure event hubs package. I'll go ahead and rebase and capture some screenshots/logs of the working setup. I'll keep you posted. Thanks! |
juan-lee
force-pushed
the
eventhub
branch
2 times, most recently
from
f09615f
to
3edc0fa
Compare
|
Here are the screenshots @johnSchnake. I also added some instructions on setting up the eventhub. |
Signed-off-by: Juan-Lee Pang <[email protected]>
|
I'd really like to be able to use the eventhub sdk provided by azure even though it brings in a few more dependencies than all of us would like to see because I'd rather not re-implement what they've already done. I'd like to propose that we not block this PR with the agreement that I'll file an issue to track the reduction in dependencies and follow up with the azure-event-hubs-go project to drive to resolution. WDYT? |
|
Did you get a chance to read my proposal? If this can't merge without reducing dependencies, that's fine. Just let me know. Thanks! |
|
Thanks @juan-lee , sorry for the time to get back to this. 👍 |
No worries. Thanks @johnSchnake! |
Signed-off-by: Juan-Lee Pang [email protected]
This pull request adds support for an Azure Event Hubs sink. The sink is inspired by the http sync, borrowing its batching and event buffering code and behavior.