Better check for FDs in net2 bindings

vixony · Mar 31, 2010 · aec80d4 · aec80d4
1 parent da16128
commit aec80d4
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/node_net2.cc b/src/node_net2.cc
@@ -50,11 +50,11 @@ static Persistent<FunctionTemplate> recv_msg_template;
 
 
 #define FD_ARG(a)                                        \
-  if (!(a)->IsInt32()) {                                 \
+  int fd;                                                \
+  if (!(a)->IsInt32() || (fd = (a)->Int32Value()) < 0) { \
     return ThrowException(Exception::TypeError(          \
           String::New("Bad file descriptor argument"))); \
-  }                                                      \
-  int fd = (a)->Int32Value();
+  }
 
 
 static inline const char *errno_string(int errorno) {