Skip to content

Commit

Permalink
test: Timeout#unref() does not return instance
Browse files Browse the repository at this point in the history
Timeout#unref() call returns undefined, not this. The test already
worked before, because the interval was still unref'd, and the test also
succeeds without clearing the interval.

PR-URL: nodejs/node-v0.x-archive#9171
Reviewed-by: Colin Ihrig <[email protected]>
Reviewed-by: Timothy J Fontaine <[email protected]>

Conflicts:
	test/simple/test-timers-unref.js
  • Loading branch information
jscissr authored and cjihrig committed Feb 13, 2015
1 parent 30dca66 commit 3b1b4de
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/parallel/test-timers-unref.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ setTimeout(function() {
interval = setInterval(function() {
unref_interval = true;
clearInterval(interval);
}, SHORT_TIME).unref();
}, SHORT_TIME);
interval.unref();

setTimeout(function() {
unref_timer = true;
Expand Down

0 comments on commit 3b1b4de

Please sign in to comment.