Skip to content

Commit

Permalink
stream: be less eager with readable flag
Browse files Browse the repository at this point in the history
As of 34b535f, test-child-process-flush-stdio was failing
on CentOS 5 systems in CI due to the change in stream state
checking in `child_process`. This commit fixes those failures
by making readable streams less eager in setting their readable
flag on EOF.

Fixes: nodejs#4125
PR-URL: nodejs#4141
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
mscdex committed Dec 4, 2015
1 parent a9c0c65 commit 2922188
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/_stream_readable.js
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,6 @@ function onEofChunk(stream, state) {
}
}
state.ended = true;
stream.readable = false;

// emit 'readable' now to make sure it gets picked up.
emitReadable(stream);
Expand Down

0 comments on commit 2922188

Please sign in to comment.