Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: module graph ensureEntryFromUrl based on id #9759

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 19, 2022

Description

Currently we check for a module existence via url in ensureEntryForUrl, but a url could map to the same resolved id that already exists in idToModulesMap (e.g. via a different url that also resolves to the same id).

This can currently happen for two URLs like:

  • /Users/foo/bar/project/src/index.js
  • /src/index.js

This PR changes to check the resolved id instead, and update the url to use the existing id & module if possible.

Additional context

Ref withastro/astro#4378
Feels related to #9730 and #7845
Something similar has been happening in SvelteKit too


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Aug 19, 2022
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this wasn't causing more issues. Let's merge it now so we can test it during the 3.1 beta. I'll run a vite-ecosystem-ci against this branch before just in case

@patak-dev
Copy link
Member

Full ecosystem CI green for this PR. There was a glitch in Rakkas, but it is now solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants