Improve variable groups; Make variable groups and factor groups hashable; Fix mypy errors #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 11, 2021
Closed
NishanthJKumar
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
LGTM after minor fix addressed! Thanks so much for figuring out the mypy issues in particular - will be sure to be more thorough with these errors in the future!
I also ran both the sanity check and heretic example to verify correctness - things seem to work!
Co-authored-by: Nishanth Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #36, #40 and #42
@NishanthJKumar I checked that sanity check example still runs fine, but I didn't check whether the results are still valid. Would be great if you can check (e.g. apply your previous "unit test", or rather an integration test). Also I don't have the heretic model code in my branch so also didn't check if the
PairwiseFactorGroupchanges break anything.As a general comment, we should in the future make more efforts to figure out why mypy is complaining instead of using
# type: ignoreextensively 😁